Skip to content

fix: fix downloading different URLs to same destination #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: fix downloading different URLs to same destination #70

wants to merge 3 commits into from
+66 −39

Conversation

spikecurtis
Copy link
Collaborator

@spikecurtis spikecurtis commented Apr 17, 2025 •
edited
Loading

fixes #69

Fixes Downloader to remove the DownloadTask when it is done via a completion. This will allow changing Coder deployments, which use different URLs but whose files are downloaded to the same place.

@spikecurtis Graphite App
Copy link
Collaborator Author

spikecurtis commented Apr 17, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis marked this pull request as ready for review April 17, 2025 12:15
@spikecurtis spikecurtis mentioned this pull request Apr 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coder Connect hangs if you sign out and sign into a different deployment
2 participants
@spikecurtis @deansheather